Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add integration test for ingest corner case test #52734

Merged
merged 9 commits into from Apr 19, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Apr 18, 2024

What problem does this PR solve?

Issue Number: close #52733

Problem Summary:
When creating index, log backup should be able to start.

What changed and how does it work?

remove the check, and add integration test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2024
Copy link

tiprow bot commented Apr 18, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@BornChanger BornChanger changed the title br: add integration test for ingest coner case test br: add integration test for ingest corner case test Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Merging #52734 (e7c0b65) into master (72e5460) will increase coverage by 2.7256%.
Report is 5 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52734        +/-   ##
================================================
+ Coverage   72.3230%   75.0486%   +2.7256%     
================================================
  Files          1471       1473         +2     
  Lines        427219     427745       +526     
================================================
+ Hits         308978     321017     +12039     
+ Misses        98951      86477     -12474     
- Partials      19290      20251       +961     
Flag Coverage Δ
integration 49.9035% <0.0000%> (?)
unit 71.1886% <0.0000%> (-0.0107%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 59.8023% <ø> (+18.6322%) ⬆️

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
ti-chi-bot bot pushed a commit to PingCAP-QE/ci that referenced this pull request Apr 19, 2024
Since pingcap/tidb#52734, we need to use
failpoint tidb-server for br integration test

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Copy link

ti-chi-bot bot commented Apr 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-19 02:19:40.663298682 +0000 UTC m=+563799.774345131: ☑️ agreed by lance6716.
  • 2024-04-19 08:32:51.174262469 +0000 UTC m=+586190.285308918: ☑️ agreed by BornChanger.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2024
@BornChanger
Copy link
Contributor

/cc @Benjamin2037

@ti-chi-bot ti-chi-bot bot requested a review from Benjamin2037 April 19, 2024 09:11
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, BornChanger, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52765.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52766.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #52767.

ti-chi-bot bot pushed a commit to PingCAP-QE/ci that referenced this pull request Apr 30, 2024
Since pingcap/tidb#52734, we need to use
failpoint tidb-server for br integration test
ti-chi-bot bot pushed a commit to PingCAP-QE/ci that referenced this pull request Apr 30, 2024
Since pingcap/tidb#52734, we need to use
failpoint tidb-server for br integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when creating index, log backup should be able to start
5 participants