executor: remove unnecessary stack for insert and load data

[jackysp]

What problem does this PR solve?

Issue Number: close #52783

Problem Summary:

What changed and how does it work?

Add stack when necessary.

master vs. this PR for completeInsertErr

Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -tags intest,deadlock -bench ^BenchmarkCompleteInsertErr$ github.com/pingcap/tidb/pkg/executor

goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/pkg/executor
BenchmarkCompleteInsertErr-8   	  383056	      3115 ns/op	     712 B/op	       8 allocs/op
PASS
ok  	github.com/pingcap/tidb/pkg/executor	4.654s

Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -tags intest,deadlock -bench ^BenchmarkCompleteInsertErr$ github.com/pingcap/tidb/pkg/executor

goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/pkg/executor
BenchmarkCompleteInsertErr-8   	 3575682	       332.1 ns/op	     200 B/op	       4 allocs/op
PASS
ok  	github.com/pingcap/tidb/pkg/executor	3.827s

master vs. this PR for completeLoadErr

Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -tags intest,deadlock -bench ^BenchmarkCompleteLoadErr$ github.com/pingcap/tidb/pkg/executor

goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/pkg/executor
BenchmarkCompleteLoadErr-8   	  595936	      2001 ns/op	     712 B/op	       8 allocs/op
PASS
ok  	github.com/pingcap/tidb/pkg/executor	3.648s

Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -tags intest,deadlock -bench ^BenchmarkCompleteLoadErr$ github.com/pingcap/tidb/pkg/executor

goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/pkg/executor
BenchmarkCompleteLoadErr-8   	 6480148	       186.4 ns/op	     200 B/op	       4 allocs/op
PASS
ok  	github.com/pingcap/tidb/pkg/executor	3.937s

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiancaiamao]

How about adding this to

tidb/pkg/executor/union_scan_test.go

Line 399 in 91fb7d3

BenchmarkUnionScanIndexLookUpDescRead,

So you can review the performance changes history like this

[jackysp]

Done, PTAL @tiancaiamao , thx!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9511%. Comparing base (05422bc) to head (cb75e08).
Report is 44 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #52784         +/-   ##
=================================================
- Coverage   70.8106%   55.9511%   -14.8596%     
=================================================
  Files          1473       1595        +122     
  Lines        409033     609407     +200374     
=================================================
+ Hits         289639     340970      +51331     
- Misses       100130     245418     +145288     
- Partials      19264      23019       +3755     

Flag	Coverage Δ
integration	36.7981% <88.8888%> (?)
unit	71.2058% <77.7777%> (+1.5713%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	49.2984% <ø> (+6.5224%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hawkingrei,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-04-21 12:31:02.526564155 +0000 UTC m=+773281.637610596: ☑️ agreed by hawkingrei.
• 2024-04-25 07:21:19.795552672 +0000 UTC m=+244836.535455584: ☑️ agreed by tiancaiamao.

[tiancaiamao]

/test mysql-test
/test check-dev2

[tiprow]

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test mysql-test
/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiancaiamao]

/test mysql-test

[tiprow]

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.