*: add rpc error stats and refine log #52810

crazycs520 · 2024-04-22T09:15:42Z

What problem does this PR solve?

Issue Number: close #52809

Related PR: tikv/client-go#1300

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: crazycs520 <crazycs520@gmail.com>

…log-and-rpc-stats

Signed-off-by: crazycs520 <crazycs520@gmail.com>

tiprow · 2024-04-22T09:15:56Z

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crazycs520 · 2024-04-22T09:15:59Z

/ok-to-test

…log-and-rpc-stats

crazycs520 · 2024-04-23T01:46:06Z

/bench

Signed-off-by: crazycs520 <crazycs520@gmail.com>

…log-and-rpc-stats

Signed-off-by: crazycs520 <crazycs520@gmail.com>

…log-and-rpc-stats

Signed-off-by: crazycs520 <crazycs520@gmail.com>

codecov · 2024-04-29T08:29:30Z

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.6547%. Comparing base (5333ac3) to head (1ae46bf).
Report is 5 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #52810         +/-   ##
=================================================
- Coverage   72.3746%   55.6547%   -16.7200%     
=================================================
  Files          1482       1596        +114     
  Lines        428762     599275     +170513     
=================================================
+ Hits         310315     333525      +23210     
- Misses        99149     242712     +143563     
- Partials      19298      23038       +3740

Flag	Coverage Δ
integration	`36.8649% <94.7368%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9957% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`50.0184% <ø> (+8.8403%)`	⬆️

ti-chi-bot · 2024-04-29T08:53:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [MyonKeminta,cfzjywxk]
~~pkg/distsql/OWNERS~~ [cfzjywxk]
~~pkg/tablecodec/OWNERS~~ [cfzjywxk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-04-29T08:53:20Z

[LGTM Timeline notifier]

Timeline:

2024-04-29 08:08:43.462959118 +0000 UTC m=+258277.220094689: ☑️ agreed by cfzjywxk.
2024-04-29 08:53:19.849449258 +0000 UTC m=+260953.606584832: ☑️ agreed by MyonKeminta.

Signed-off-by: crazycs520 <crazycs520@gmail.com>

crazycs520 · 2024-04-29T11:28:16Z

/retest-required

Signed-off-by: crazycs520 <crazycs520@gmail.com>

ti-chi-bot · 2024-04-30T02:17:37Z

In response to a cherrypick label: new pull request created to branch release-8.1: #52998.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

close #52809

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <zhongyangguan@gmail.com> * *: add rpc error stats and refine log (#52810) Signed-off-by: crazycs520 <crazycs520@gmail.com> * store: refine coprocessor error log (#52729) Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: improve log about stale-read query (#52494) Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (#45559) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add leader peer id log Signed-off-by: crazycs520 <crazycs520@gmail.com> * update log Signed-off-by: crazycs520 <crazycs520@gmail.com> * executor: fix issue that some query execution stats was omitted when execution was interrupted (#51787) close #51660 Signed-off-by: crazycs520 <crazycs520@gmail.com> * update go.mod Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: zyguan <zhongyangguan@gmail.com> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com>

…#53335) (pingcap#96) * *: add rpc error stats and refine log for diagnose (pingcap#53335) * sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <zhongyangguan@gmail.com> * *: add rpc error stats and refine log (pingcap#52810) Signed-off-by: crazycs520 <crazycs520@gmail.com> * store: refine coprocessor error log (pingcap#52729) Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: improve log about stale-read query (pingcap#52494) Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (pingcap#45559) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add leader peer id log Signed-off-by: crazycs520 <crazycs520@gmail.com> * update log Signed-off-by: crazycs520 <crazycs520@gmail.com> * executor: fix issue that some query execution stats was omitted when execution was interrupted (pingcap#51787) close pingcap#51660 Signed-off-by: crazycs520 <crazycs520@gmail.com> * update go.mod Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: zyguan <zhongyangguan@gmail.com> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com> * Update go.sum * Update go.mod --------- Signed-off-by: zyguan <zhongyangguan@gmail.com> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com>

crazycs520 added 19 commits April 9, 2024 18:23

refine log and rpc stats

43e4a62

Signed-off-by: crazycs520 <crazycs520@gmail.com>

tiny fix

65495b4

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update tikv/client-go

5392872

Signed-off-by: crazycs520 <crazycs520@gmail.com>

executor: fix issue of txn_ts of stale-read query is 0 in slow log

0b49034

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update tikv/client-go

1420f7c

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update tikv/client-go

a2d647e

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update tikv/client-go

352186b

Signed-off-by: crazycs520 <crazycs520@gmail.com>

init

6accf1b

Signed-off-by: crazycs520 <crazycs520@gmail.com>

Merge branch 'master' of https://github.com/pingcap/tidb into refine-…

c3bc494

…log-and-rpc-stats

update

1b27adb

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update

64bc7a3

Signed-off-by: crazycs520 <crazycs520@gmail.com>

refine

df50e4f

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update

9071c8a

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update

028746a

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update

6dab1c3

Signed-off-by: crazycs520 <crazycs520@gmail.com>

refine code

7df3b0e

Signed-off-by: crazycs520 <crazycs520@gmail.com>

refine string method

30968ec

Signed-off-by: crazycs520 <crazycs520@gmail.com>

refine code

19e78a2

Signed-off-by: crazycs520 <crazycs520@gmail.com>

update

d5e507b

Signed-off-by: crazycs520 <crazycs520@gmail.com>

crazycs520 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024

ti-chi-bot bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 22, 2024

ti-chi-bot bot added the ok-to-test label Apr 22, 2024

Merge branch 'master' of https://github.com/pingcap/tidb into refine-…

5805f55

…log-and-rpc-stats

crazycs520 added 2 commits April 24, 2024 11:08

update

435af22

Signed-off-by: crazycs520 <crazycs520@gmail.com>

Merge branch 'master' of https://github.com/pingcap/tidb into refine-…

b237346

…log-and-rpc-stats

cfzjywxk requested review from zyguan, MyonKeminta and ekexium April 29, 2024 08:07

cfzjywxk approved these changes Apr 29, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm labels Apr 29, 2024

crazycs520 added 3 commits April 29, 2024 16:21

fix test

1efc9cf

Signed-off-by: crazycs520 <crazycs520@gmail.com>

Merge branch 'master' of https://github.com/pingcap/tidb into refine-…

95c17d5

…log-and-rpc-stats

make bazel_prepare

6492ed6

Signed-off-by: crazycs520 <crazycs520@gmail.com>

MyonKeminta approved these changes Apr 29, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm labels Apr 29, 2024

crazycs520 added 3 commits April 29, 2024 17:04

fix test

18e6b6f

Signed-off-by: crazycs520 <crazycs520@gmail.com>

fix test

3bff761

Signed-off-by: crazycs520 <crazycs520@gmail.com>

fix test

b563c96

Signed-off-by: crazycs520 <crazycs520@gmail.com>

fix test

1ae46bf

Signed-off-by: crazycs520 <crazycs520@gmail.com>

ti-chi-bot bot merged commit 245f7a9 into pingcap:master Apr 29, 2024
20 of 23 checks passed

crazycs520 added the needs-cherry-pick-release-8.1 label Apr 30, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 30, 2024

This is an automated cherry-pick of pingcap#52810

05cac2e

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Apr 30, 2024

*: add rpc error stats and refine log (#52810) #52998

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024

*: add rpc error stats and refine log (#52810) (#52998)

1f1544b

close #52809

crazycs520 added a commit to crazycs520/tidb that referenced this pull request May 15, 2024

*: add rpc error stats and refine log (pingcap#52810)

1cb8533

Signed-off-by: crazycs520 <crazycs520@gmail.com>

crazycs520 mentioned this pull request May 21, 2024

*: add rpc error stats and refine log for diagnose #53335

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: add rpc error stats and refine log #52810

*: add rpc error stats and refine log #52810

crazycs520 commented Apr 22, 2024 •

edited

tiprow bot commented Apr 22, 2024

crazycs520 commented Apr 22, 2024

crazycs520 commented Apr 23, 2024

codecov bot commented Apr 29, 2024 •

edited

ti-chi-bot bot commented Apr 29, 2024

ti-chi-bot bot commented Apr 29, 2024

crazycs520 commented Apr 29, 2024

ti-chi-bot commented Apr 30, 2024

*: add rpc error stats and refine log #52810

*: add rpc error stats and refine log #52810

Conversation

crazycs520 commented Apr 22, 2024 • edited

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Apr 22, 2024

crazycs520 commented Apr 22, 2024

crazycs520 commented Apr 23, 2024

codecov bot commented Apr 29, 2024 • edited

Codecov Report

ti-chi-bot bot commented Apr 29, 2024

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

crazycs520 commented Apr 29, 2024

ti-chi-bot commented Apr 30, 2024

crazycs520 commented Apr 22, 2024 •

edited

codecov bot commented Apr 29, 2024 •

edited