Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cop: ignore locks with the same start_ts (#52461) #52832

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52461

What problem does this PR solve?

Issue Number: close #52460

Problem Summary:

What changed and how does it work?

If this cop is not a stale read, which means its start_ts is fetched from PD, which means the start_ts cannot conflict with other transactions, add this ts to resolved_locks so that in a pipelined txn the locks belonging to the same txn will not block coprocessor.

For get and batch_get, they already put start_ts in resolved_locks.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below): repeating insert into t select * from t no longer reports resolve lock timeout error. I found it hard to be tested in unit test.
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ekexium <eke@fastmail.com>
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.1@cfeca9b). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52832   +/-   ##
================================================
  Coverage               ?   72.2701%           
================================================
  Files                  ?       1468           
  Lines                  ?     426934           
  Branches               ?          0           
================================================
  Hits                   ?     308546           
  Misses                 ?      99095           
  Partials               ?      19293           
Flag Coverage Δ
unit 71.1408% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0929% <0.0000%> (?)

@cfzjywxk
Copy link
Contributor

/merge

Copy link

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 23, 2024
Copy link

ti-chi-bot bot commented Apr 23, 2024

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-23 06:03:37.410386367 +0000 UTC m=+67374.150289279: ☑️ agreed by you06.
  • 2024-04-23 07:44:49.837477811 +0000 UTC m=+73446.577380734: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 34a4dca into pingcap:release-8.1 Apr 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants