Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: try other PDs if one cannot serve the request #52843

Merged
merged 1 commit into from
May 6, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 23, 2024

What problem does this PR solve?

Issue Number: close #52842.

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Use tiup to deploy a cluster and execute select * from cluster_info; with 3 PD.
Screenshot 2024-04-23 at 17 49 48

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2024
@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8928%. Comparing base (224ae15) to head (8dfc8f0).
Report is 115 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52843        +/-   ##
================================================
+ Coverage   74.3558%   74.8928%   +0.5369%     
================================================
  Files          1470       1506        +36     
  Lines        354521     458988    +104467     
================================================
+ Hits         263607     343749     +80142     
- Misses        71638      94662     +23024     
- Partials      19276      20577      +1301     
Flag Coverage Δ
integration 49.4248% <100.0000%> (?)
unit 71.3013% <100.0000%> (-1.8260%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 46.8236% <ø> (+4.1837%) ⬆️

@rleungx
Copy link
Member Author

rleungx commented May 6, 2024

/test unit-test

Copy link

ti-chi-bot bot commented May 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-06 05:45:51.967194744 +0000 UTC m=+854505.724330315: ☑️ agreed by JmPotato.
  • 2024-05-06 06:52:04.325300882 +0000 UTC m=+858478.082436455: ☑️ agreed by xhebox.

@rleungx
Copy link
Member Author

rleungx commented May 6, 2024

/merge

Copy link

ti-chi-bot bot commented May 6, 2024

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented May 6, 2024

/approve

Copy link

ti-chi-bot bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 659f32a into pingcap:master May 6, 2024
22 of 23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53030.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
6 participants