Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump up client-go to fix #52464 #52844

Merged
merged 4 commits into from Apr 24, 2024
Merged

*: bump up client-go to fix #52464 #52844

merged 4 commits into from Apr 24, 2024

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Apr 23, 2024

What problem does this PR solve?

Issue Number: close #52464

Problem Summary: LocateKey may returns a wrong region

What changed and how does it work?

The fix is included in tikv/client-go#1299, thus bump up client-go.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2024
Copy link

tiprow bot commented Apr 23, 2024

Hi @zyguan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zyguan
Copy link
Contributor Author

zyguan commented Apr 23, 2024

/ok-to-test

@zyguan
Copy link
Contributor Author

zyguan commented Apr 23, 2024

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@zyguan: once the present PR merges, I will cherry-pick it on top of release-8.1 in the new PR and assign it to you.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-23 10:30:02.369016594 +0000 UTC m=+83359.108919505: ☑️ agreed by MyonKeminta.
  • 2024-04-23 10:31:50.865235754 +0000 UTC m=+83467.605138666: ☑️ agreed by cfzjywxk.

@cfzjywxk
Copy link
Contributor

/merge

Copy link

ti-chi-bot bot commented Apr 23, 2024

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #52844 (a714e23) into master (42d58b5) will increase coverage by 2.2559%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52844        +/-   ##
================================================
+ Coverage   72.3805%   74.6364%   +2.2559%     
================================================
  Files          1477       1480         +3     
  Lines        427995     431829      +3834     
================================================
+ Hits         309785     322302     +12517     
+ Misses        98964      89632      -9332     
- Partials      19246      19895       +649     
Flag Coverage Δ
integration 49.1071% <ø> (?)
unit 71.3711% <ø> (+0.1206%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7688% <ø> (+8.5797%) ⬆️

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2024
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@cfzjywxk
Copy link
Contributor

/retest

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@you06
Copy link
Contributor

you06 commented Apr 24, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit c0e6cba into pingcap:master Apr 24, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

@zyguan: new pull request created to branch release-8.1: #52871.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql report "Error 1105 (HY000): other error: Request range exceeds bound" after flashback
6 participants