Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: handle region leader miss (#52822) #52855

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52822

What problem does this PR solve?

Issue Number: close #51124 close #50501

Problem Summary:
the leader of region, scanned from PD, is nil

What changed and how does it work?

check regions' leader after scan from PD.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 labels Apr 24, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2024
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 6, 2024
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 22, 2024
@Leavrth
Copy link
Contributor

Leavrth commented May 22, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented May 22, 2024

@Leavrth: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-22 07:33:32.199194248 +0000 UTC m=+2243365.956329822: ☑️ agreed by lance6716.
  • 2024-05-22 09:13:55.497336271 +0000 UTC m=+2249389.254471843: ☑️ agreed by YuJuncen.

@Leavrth
Copy link
Contributor

Leavrth commented May 22, 2024

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented May 23, 2024

/retest

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2024
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@e406d57). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52855   +/-   ##
================================================
  Coverage               ?   71.9948%           
================================================
  Files                  ?       1411           
  Lines                  ?     410253           
  Branches               ?          0           
================================================
  Hits                   ?     295361           
  Misses                 ?      95027           
  Partials               ?      19865           
Flag Coverage Δ
unit 71.9948% <36.3636%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4049% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit c149ae8 into pingcap:release-7.5 May 23, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants