Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: collect and move correlated utility to util pkg #52866

Merged
merged 5 commits into from Apr 25, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Apr 24, 2024

What problem does this PR solve?

Issue Number: ref #51664, ref #52714

Problem Summary:

What changed and how does it work?

// optimizetrace and costusage is isolated from util because core/base depended on them for
// interface definition. Ideally, the dependency chain should not be:
//
// `base` <- `util`/`util.coreusage` <- `core`
//    ^ +---------------^                  |
//    +------------------------------------+
//
// since `base` depended on optimizetrace and costusage for definition, we should separate
// them out of `util`/`util.coreusage` to avoid import cycle. It should be:
//
// util.optimizetrace/util.costusage  <- `base` <- `util`/`util.coreusage` <- `core`
//   				^   		            ^                   ||
//   				|   		            +-------------------+|
//                              +------------------------------------------------+
//

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 24, 2024
Copy link

tiprow bot commented Apr 24, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 91.49378% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 55.8314%. Comparing base (e349c7c) to head (a6bf518).
Report is 13 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52866         +/-   ##
=================================================
- Coverage   72.3937%   55.8314%   -16.5623%     
=================================================
  Files          1479       1594        +115     
  Lines        428261     601652     +173391     
=================================================
+ Hits         310034     335911      +25877     
- Misses        98972     242737     +143765     
- Partials      19255      23004       +3749     
Flag Coverage Δ
integration 37.1538% <86.7219%> (?)
unit 71.3965% <91.0788%> (+0.1212%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.6930% <ø> (+8.4638%) ⬆️

@AilinKid
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Apr 24, 2024

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

Copy link

ti-chi-bot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-24 10:15:56.173877793 +0000 UTC m=+168912.913780704: ☑️ agreed by hawkingrei.
  • 2024-04-25 06:18:34.150405157 +0000 UTC m=+241070.890308064: ☑️ agreed by zimulala.

@AilinKid
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Apr 25, 2024

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit e8c397f into pingcap:master Apr 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants