-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flashback: fix realtikvtest/flashbacktest
test cases
#52899
Conversation
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test fast_test_tiprow |
@Defined2014: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52899 +/- ##
=================================================
- Coverage 72.4341% 55.9040% -16.5302%
=================================================
Files 1481 1587 +106
Lines 428353 594129 +165776
=================================================
+ Hits 310274 332142 +21868
- Misses 98884 239046 +140162
- Partials 19195 22941 +3746
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
I'm OK to merge this PR. But I guess it is better to ignore those system ddls in Sender(DDL moudle) side. It would help us avoid this kind of bug happen again and avoid pass schema id to every event. I am on the holiday and I will be back next month. Perhaps we can merge this one and I will try to improve it after I get back. |
Now only the required ddl will send the event. Flashback sends this event to update the ts of the stats table, so it has nothing to do with the schema. @hi-rustin |
/unhold |
Got it. I misunderstood it. Thank you. |
What problem does this PR solve?
Issue Number: close #52898
Problem Summary: After #52285, flashbacktest alwayws failed with error info like
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.