util/chunk: add List to holds a slice of Chunk. #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to properly handle max chunk size when appending row.
|
/rebuild |
zz-jason
reviewed
Dec 4, 2017
| ) | ||
|
|
||
| // List holds a slice of chunks, use to append rows with max chunk size properly handled. | ||
| type List struct { |
There was a problem hiding this comment.
In what scenario should we use this ?
There was a problem hiding this comment.
Sort and TopN can use it to simplify the logic.
And the IndexLookUpJoin need it too because we need index batch size greater than max chunk size.
|
LGTM |
XuHuaiyu
reviewed
Dec 4, 2017
util/chunk/list_test.go
Outdated
| } | ||
| c.Assert(l.NumChunks(), check.Equals, 3) | ||
| c.Assert(l.Len(), check.Equals, 5) | ||
|
|
There was a problem hiding this comment.
check len(l.freelist) == 0 here
rest LGTM
XuHuaiyu
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to properly handle max chunk size when appending row.