Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the unstable test TestCaptureWildcardFilter #52946

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 28, 2024

What problem does this PR solve?

Issue Number: close #40297

Problem Summary: planner: fix the unstable test TestCaptureWildcardFilter

What changed and how does it work?

the old implementation of Capture is considered as deprecated

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2024
Copy link

tiprow bot commented Apr 28, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-28 08:19:32.700024156 +0000 UTC m=+172526.457159732: ☑️ agreed by AilinKid.
  • 2024-04-28 08:19:47.567455617 +0000 UTC m=+172541.324591188: ☑️ agreed by time-and-fate.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.1432%. Comparing base (0412aa1) to head (f5d241f).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52946         +/-   ##
=================================================
- Coverage   72.3621%   56.1432%   -16.2190%     
=================================================
  Files          1482       1593        +111     
  Lines        428430     601161     +172731     
=================================================
+ Hits         310021     337511      +27490     
- Misses        99117     240695     +141578     
- Partials      19292      22955       +3663     
Flag Coverage Δ
integration 37.5520% <ø> (?)
unit 71.7127% <ø> (+0.4891%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.8794% <ø> (+8.7254%) ⬆️

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 28, 2024

/test check-dev2

Copy link

tiprow bot commented Apr 28, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 29, 2024

/test pull-mysql-client-test

Copy link

tiprow bot commented Apr 29, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-mysql-client-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 3fc5704 into pingcap:master Apr 29, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestCaptureWildcardFilter
3 participants