Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: modify the printing of column default expression in SHOW CREATE TABLE and Restore (#52940) #52951

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52940

What problem does this PR solve?

Issue Number: close #52939

Problem Summary:

See the description of the issue.

What changed and how does it work?

If the column default expression is ast.FuncCallExpr except ast.CurrentTimestamp, wrap an outer parentheses in SHOW CREATE TABLE and Restore()

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Wrap some column default expressions within parentheses in SHOW CREATE TABLE and Restore

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@CbcWestwolf CbcWestwolf force-pushed the cherry-pick-52940-to-release-7.5 branch from fda9b9b to 8567f64 Compare April 28, 2024 14:48
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-7.5@0359bbc). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52951   +/-   ##
================================================
  Coverage               ?   71.9867%           
================================================
  Files                  ?       1410           
  Lines                  ?     409492           
  Branches               ?          0           
================================================
  Hits                   ?     294780           
  Misses                 ?      94877           
  Partials               ?      19835           
Flag Coverage Δ
unit 71.9867% <85.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3534% <0.0000%> (?)

@easonn7
Copy link

easonn7 commented Apr 29, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, easonn7, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 01:36:58.705782351 +0000 UTC m=+234772.462917919: ☑️ agreed by CbcWestwolf.
  • 2024-04-29 01:52:48.842041829 +0000 UTC m=+235722.599177401: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit bf84e23 into pingcap:release-7.5 Apr 29, 2024
18 checks passed
@CbcWestwolf CbcWestwolf deleted the cherry-pick-52940-to-release-7.5 branch April 29, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants