-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix the issue about create columns with wrong default when sql_mode is empty. #52988
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52988 +/- ##
=================================================
- Coverage 72.3811% 55.7545% -16.6266%
=================================================
Files 1482 1597 +115
Lines 428743 600172 +171429
=================================================
+ Hits 310329 334623 +24294
- Misses 99115 242466 +143351
- Partials 19299 23083 +3784
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dc5079f
to
800b0b0
Compare
/retest |
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
…ode is empty. (pingcap#52988) close pingcap#51320, close pingcap#52972
/cherry-pick release-6.5 |
@lance6716: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #52972, close #51320
Problem Summary:
Case1:
Case2:
Now the TiDB behaviors:
@@sql_mode
isSTRICT_TRANS_TABLES
(Case1) the result isInvalid default value for 'b'
.@@sql_mode
is''
(Case2) the result is successful.Now the MySQL(MySQL 5.7.44 and 8.0.18 MySQL) behaviors:
Invalid default value for 'b'
.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.