Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the issue about create columns with wrong default when sql_mode is empty. #52988

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Apr 29, 2024

What problem does this PR solve?

Issue Number: close #52972, close #51320

Problem Summary:
Case1:

set @@sql_mode='STRICT_TRANS_TABLES';
drop table if exists t1;
create table t1(a int);
insert into t1 values(1);
alter table t1 add column(b tinyint default '11111111');

Case2:

set @@sql_mode='';
drop table if exists t1;
create table t1(a int);
insert into t1 values(1);
alter table t1 add column(b tinyint default '11111111');

Now the TiDB behaviors:

  • When the @@sql_mode is STRICT_TRANS_TABLES(Case1) the result is Invalid default value for 'b'.
  • When the @@sql_mode is ''(Case2) the result is successful.

Now the MySQL(MySQL 5.7.44 and 8.0.18 MySQL) behaviors:

  • In Both cases the result is Invalid default value for 'b'.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2024
Copy link

tiprow bot commented Apr 29, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.7545%. Comparing base (1d698c7) to head (800b0b0).
Report is 12 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52988         +/-   ##
=================================================
- Coverage   72.3811%   55.7545%   -16.6266%     
=================================================
  Files          1482       1597        +115     
  Lines        428743     600172     +171429     
=================================================
+ Hits         310329     334623      +24294     
- Misses        99115     242466     +143351     
- Partials      19299      23083       +3784     
Flag Coverage Δ
integration 37.1662% <85.7142%> (?)
unit 71.2434% <100.0000%> (+0.0249%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.2175% <ø> (+8.0736%) ⬆️

@zimulala
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Apr 30, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-30 02:37:33.103366475 +0000 UTC m=+324806.860502042: ☑️ agreed by Defined2014.
  • 2024-04-30 06:26:19.64581038 +0000 UTC m=+338533.402945950: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 2343c54 into pingcap:master Apr 30, 2024
21 of 23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53002.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request May 7, 2024
@zimulala zimulala deleted the zimuxia/col-default branch May 14, 2024 01:59
@lance6716
Copy link
Contributor

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@lance6716: new pull request created to branch release-6.5: #53736.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 3, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants