Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump client-go to fix #53011 #53012

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

you06
Copy link
Contributor

@you06 you06 commented Apr 30, 2024

What problem does this PR solve?

Issue Number: close #53011 ref #50215

Problem Summary:

What changed and how does it work?

The client-go patch let the pipelined DML abort once the max ttl is exceeded, and avoid writing useless locks which slow down GC.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2024
Copy link

tiprow bot commented Apr 30, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.6901%. Comparing base (2343c54) to head (618cfbc).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53012         +/-   ##
=================================================
- Coverage   72.3920%   54.6901%   -17.7019%     
=================================================
  Files          1483       1613        +130     
  Lines        429021     600887     +171866     
=================================================
+ Hits         310577     328626      +18049     
- Misses        99142     250159     +151017     
- Partials      19302      22102       +2800     
Flag Coverage Δ
integration 35.4785% <ø> (?)
unit 71.2296% <ø> (-0.0008%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 38.7673% <56.1342%> (-2.4451%) ⬇️

@you06
Copy link
Contributor Author

you06 commented May 1, 2024

/retest

Copy link

tiprow bot commented May 1, 2024

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented May 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-30 16:03:50.456233205 +0000 UTC m=+373184.213368779: ☑️ agreed by ekexium.
  • 2024-05-01 02:44:10.346121028 +0000 UTC m=+411604.103256600: ☑️ agreed by wshwsh12.

@you06
Copy link
Contributor Author

you06 commented May 1, 2024

/merge

Copy link

ti-chi-bot bot commented May 1, 2024

@you06: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

ti-chi-bot bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, ekexium, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,ekexium,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 600b2ed into pingcap:master May 1, 2024
21 of 23 checks passed
@you06 you06 deleted the bump/client-go branch May 1, 2024 02:52
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53015.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 1, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 2, 2024
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelined DML do not abort after 24h
5 participants