Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: small refactor for plan cache #53028

Merged
merged 5 commits into from
May 6, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 6, 2024

What problem does this PR solve?

Issue Number: ref #50618

Problem Summary: planner: small refactor for plan cache

What changed and how does it work?

planner: small refactor for plan cache

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.1644%. Comparing base (516977e) to head (83103c1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53028        +/-   ##
================================================
+ Coverage   72.0377%   74.1644%   +2.1266%     
================================================
  Files          1499       1499                
  Lines        431246     431282        +36     
================================================
+ Hits         310660     319858      +9198     
+ Misses       101286      91598      -9688     
- Partials      19300      19826       +526     
Flag Coverage Δ
integration 49.0318% <100.0000%> (?)
unit 71.2662% <100.0000%> (+0.0117%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5726% <ø> (+8.2205%) ⬆️

Copy link
Member

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 👍

Copy link

ti-chi-bot bot commented May 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-06 08:21:45.790532715 +0000 UTC m=+863859.547668280: ☑️ agreed by hawkingrei.
  • 2024-05-06 08:23:30.817797231 +0000 UTC m=+863964.574932804: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot added the approved label May 6, 2024
Copy link

ti-chi-bot bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, hi-rustin, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 17d3f7f into pingcap:master May 6, 2024
21 checks passed
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request May 7, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants