Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: disable tidb_enable_historical_stats by default #53046

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 7, 2024

What problem does this PR solve?

Issue Number: close #53048

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.4494%. Comparing base (06ee59b) to head (b3317f2).
Report is 13 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53046        +/-   ##
================================================
+ Coverage   72.0208%   74.4494%   +2.4286%     
================================================
  Files          1499       1508         +9     
  Lines        431246     438719      +7473     
================================================
+ Hits         310587     326624     +16037     
+ Misses       101361      91959      -9402     
- Partials      19298      20136       +838     
Flag Coverage Δ
integration 49.1384% <ø> (?)
unit 71.3063% <ø> (+0.0747%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 47.3160% <ø> (+8.9514%) ⬆️

@easonn7
Copy link

easonn7 commented May 7, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label May 7, 2024
@hawkingrei
Copy link
Member Author

/retest

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei requested a review from hi-rustin May 7, 2024 03:37
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

ti-chi-bot bot commented May 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 03:25:18.095935034 +0000 UTC m=+932471.853070599: ☑️ agreed by AilinKid.
  • 2024-05-07 05:38:10.118717689 +0000 UTC m=+940443.875853247: ☑️ agreed by hi-rustin.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
Copy link

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, easonn7, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 81a7cf5 into pingcap:master May 7, 2024
21 checks passed
@hawkingrei hawkingrei deleted the disable_tidb_enable_historical_stats branch May 7, 2024 12:51
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve tidb_enable_historical_stats to avoid oom
4 participants