Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "planner: merge fast plan cache and normal plan cache" #53084

Merged
merged 1 commit into from
May 7, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 7, 2024

What problem does this PR solve?

Issue Number: ref #50618

Problem Summary: planner: merge fast plan cache and normal plan cache

What changed and how does it work?

revert #53033, which causes some performance regression on BenchmarkPreparedPointGet: 6305 ns/op --> 9011 ns/op

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels May 7, 2024
Copy link

ti-chi-bot bot commented May 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 11:29:25.403574658 +0000 UTC m=+961519.160710229: ☑️ agreed by AilinKid.
  • 2024-05-07 11:33:05.517724269 +0000 UTC m=+961739.274859858: ☑️ agreed by hawkingrei.

Copy link

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.0735%. Comparing base (81a7cf5) to head (b0c4ac1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53084        +/-   ##
================================================
+ Coverage   72.0185%   74.0735%   +2.0550%     
================================================
  Files          1508       1508                
  Lines        434859     435956      +1097     
================================================
+ Hits         313179     322928      +9749     
+ Misses       102094      92923      -9171     
- Partials      19586      20105       +519     
Flag Coverage Δ
integration 48.8770% <76.5957%> (?)
unit 71.2294% <80.8510%> (+0.0058%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 46.6494% <ø> (+8.1629%) ⬆️

@qw4990
Copy link
Contributor Author

qw4990 commented May 7, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 5798dc6 into master May 7, 2024
21 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-53033-merge-cached-fast-plan branch May 7, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants