-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "planner: merge fast plan cache and normal plan cache" #53084
Conversation
This reverts commit b421b72.
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53084 +/- ##
================================================
+ Coverage 72.0185% 74.0735% +2.0550%
================================================
Files 1508 1508
Lines 434859 435956 +1097
================================================
+ Hits 313179 322928 +9749
+ Misses 102094 92923 -9171
- Partials 19586 20105 +519
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
What problem does this PR solve?
Issue Number: ref #50618
Problem Summary: planner: merge fast plan cache and normal plan cache
What changed and how does it work?
revert #53033, which causes some performance regression on BenchmarkPreparedPointGet:
6305 ns/op
-->9011 ns/op
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.