Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the primary key in index is not in restored format #53118

Merged
merged 1 commit into from
May 9, 2024

Conversation

djshow832
Copy link
Contributor

@djshow832 djshow832 commented May 9, 2024

What problem does this PR solve?

Issue Number: close #52510

Problem Summary:
when fast reorg and new collation are enabled, index backfilling only considers the need to restore the index columns, but ignores the primary key columns. The result is that the primary key in the index is not restored.

What changed and how does it work?

When considering the need to restore an index, check both the index columns and the primary key columns.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Fix the collation of the primary key in secondary indexes is wrong when tidb_ddl_enable_fast_reorg is enabled

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2024
Copy link

tiprow bot commented May 9, 2024

Hi @djshow832. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5181%. Comparing base (a5c4031) to head (d648135).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53118        +/-   ##
================================================
+ Coverage   74.4476%   74.5181%   +0.0704%     
================================================
  Files          1491       1491                
  Lines        356034     429247     +73213     
================================================
+ Hits         265059     319867     +54808     
- Misses        71741      89500     +17759     
- Partials      19234      19880       +646     
Flag Coverage Δ
integration 49.0953% <100.0000%> (?)
unit 71.2518% <100.0000%> (-1.9586%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 50.3387% <ø> (+7.4583%) ⬆️

Copy link

ti-chi-bot bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-09 06:05:57.942962495 +0000 UTC m=+1114911.700098114: ☑️ agreed by wjhuang2016.
  • 2024-05-09 06:22:31.13350693 +0000 UTC m=+1115904.890642503: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 12b37d8 into pingcap:master May 9, 2024
23 checks passed
@djshow832 djshow832 deleted the fix_restore branch May 9, 2024 07:18
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data inconsistency after creating multi-value index
4 participants