expression: reverts #53129 | tidb-test=pr/2329

[solotzg]

Reverts #53129

What problem does this PR solve?

Issue Number: close #53248

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

[tiprow]

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[solotzg]

/retest

[tiprow]

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5619%. Comparing base (a2037fe) to head (ec849d1).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53259        +/-   ##
================================================
+ Coverage   72.4460%   74.5619%   +2.1159%     
================================================
  Files          1493       1493                
  Lines        429361     429778       +417     
================================================
+ Hits         311055     320451      +9396     
+ Misses        99031      89440      -9591     
- Partials      19275      19887       +612     

Flag	Coverage Δ
integration	49.1431% <100.0000%> (?)
unit	71.2627% <100.0000%> (-0.0796%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	50.4517% <ø> (+9.0215%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/expression/OWNERS [XuHuaiyu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-14 09:47:44.617979634 +0000 UTC m=+1560218.375115191: ☑️ agreed by XuHuaiyu.
• 2024-05-14 09:52:46.624617815 +0000 UTC m=+1560520.381753388: ☑️ agreed by guo-shaoge.

[solotzg]

/retest

[tiprow]

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-53259-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-53259-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}