Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: check delete unique key's handle to handle corner case (#52975) #53333

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52975

What problem does this PR solve?

Issue Number: close #52914

Problem Summary:
Take the case from the issue, if an insert is executed during delete only, there is no record on the temporary index.
Before the merge process, a delete operation may delete the index key value(generated by ingest) unexpectedly.
To avoid this problem, we need to check if the delete value's handle is the same as we want to delete.
If not, it means that the value we want to delete is covered by another value already, which shouldn't be deleted again.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix a bug which may cause data consistency problem when adding unique index 

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 20 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-8.1@e40b817). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53333   +/-   ##
================================================
  Coverage               ?   71.1527%           
================================================
  Files                  ?       1465           
  Lines                  ?     421444           
  Branches               ?          0           
================================================
  Hits                   ?     299869           
  Misses                 ?     101101           
  Partials               ?      20474           
Flag Coverage Δ
unit 71.1527% <28.5714%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9536% <0.0000%> (?)

@jebter
Copy link

jebter commented May 16, 2024

/retest-required

@wjhuang2016
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-16 09:36:19.91232053 +0000 UTC m=+1732333.669456104: ☑️ agreed by tangenta.
  • 2024-05-16 12:12:12.558021709 +0000 UTC m=+1741686.315157293: ☑️ agreed by wjhuang2016.

@jebter
Copy link

jebter commented May 16, 2024

/retest

3 similar comments
@jebter
Copy link

jebter commented May 16, 2024

/retest

@jebter
Copy link

jebter commented May 16, 2024

/retest

@wjhuang2016
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

1 similar comment
@wjhuang2016
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 017e8bb into pingcap:release-8.1 May 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants