Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump client-go to fix #51921 (#52026) #53447

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52026

What problem does this PR solve?

Issue Number: close #51921

Problem Summary: When a kv request timeout, there might be data race on XxxRequest.Context.

What changed and how does it work?

The issue shall be fixed at client-go, this PR upgrade the dependency.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 labels May 21, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 21, 2024
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 21, 2024
@cfzjywxk
Copy link
Contributor

@zyguan Please refine the pick PR

@zyguan
Copy link
Contributor

zyguan commented May 22, 2024

@zyguan Please refine the pick PR

@cfzjywxk tikv/client-go#1351 is required.

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@cfzjywxk
Copy link
Contributor

/merge

Copy link

ti-chi-bot bot commented May 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-28 03:16:07.035287784 +0000 UTC m=+2746320.792423355: ☑️ agreed by MyonKeminta.
  • 2024-05-28 03:23:00.189678774 +0000 UTC m=+2746733.946814347: ☑️ agreed by cfzjywxk.

Copy link

ti-chi-bot bot commented May 28, 2024

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

ti-chi-bot bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crazycs520
Copy link
Contributor

/retest-required

@cfzjywxk
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented May 28, 2024

@cfzjywxk: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cfzjywxk
Copy link
Contributor

/retest-required

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@zyguan
Copy link
Contributor

zyguan commented May 28, 2024

/retest

@zyguan
Copy link
Contributor

zyguan commented May 28, 2024

/retest

2 similar comments
@zyguan
Copy link
Contributor

zyguan commented May 28, 2024

/retest

@zyguan
Copy link
Contributor

zyguan commented May 28, 2024

/retest

@cfzjywxk
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented May 28, 2024

@cfzjywxk: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zyguan
Copy link
Contributor

zyguan commented May 28, 2024

/retest

@zyguan
Copy link
Contributor

zyguan commented May 28, 2024

/retest

1 similar comment
@zyguan
Copy link
Contributor

zyguan commented May 28, 2024

/retest

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@a8087f7). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53447   +/-   ##
================================================
  Coverage               ?   72.0057%           
================================================
  Files                  ?       1411           
  Lines                  ?     410631           
  Branches               ?          0           
================================================
  Hits                   ?     295678           
  Misses                 ?      95054           
  Partials               ?      19899           
Flag Coverage Δ
unit 72.0057% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4567% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 7a93d06 into pingcap:release-7.5 May 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants