-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Do not save long-lived unsafe.Pointer in hash join v2 #54085
base: master
Are you sure you want to change the base?
executor: Do not save long-lived unsafe.Pointer in hash join v2 #54085
Conversation
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufei@pingcap.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @windtalker. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54085 +/- ##
=================================================
- Coverage 74.5294% 56.0568% -18.4727%
=================================================
Files 1516 1636 +120
Lines 360821 606559 +245738
=================================================
+ Hits 268918 340018 +71100
- Misses 72393 243245 +170852
- Partials 19510 23296 +3786
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: ref #53127
Problem Summary:
In #53208, it creates a lots of long-lived
unsafe.Pointer
during hash join's build, a simple performance test shows lots ofunsafe.Pointer
will significantly increases gc time:gc with a lots of unsafe.Pointer
gc with a lots of uintptr
So this pr remove all the long-lived
unsafe.Pointer
during hash join v2. For the variable that used to beunsafe.Pointer
, this pr useuintptr
instead. And go runtime actually forbit to convertuintptr
tounsafe.Pointer
directly, this pr use the follow hack to read/writeunsafe.Pointer
from/touintptr
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.