Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: update pd client #54424

Merged
merged 1 commit into from
Jul 4, 2024
Merged

mod: update pd client #54424

merged 1 commit into from
Jul 4, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jul 3, 2024

What problem does this PR solve?

Issue Number: ref #47421 ref tikv/pd#8349

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@sre-bot
Copy link
Contributor

sre-bot commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.1192%. Comparing base (97d838b) to head (0030d96).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54424         +/-   ##
=================================================
- Coverage   72.8044%   56.1192%   -16.6853%     
=================================================
  Files          1537       1658        +121     
  Lines        435939     608718     +172779     
=================================================
+ Hits         317383     341608      +24225     
- Misses        98926     243785     +144859     
- Partials      19630      23325       +3695     
Flag Coverage Δ
integration 37.1734% <ø> (?)
unit 71.9201% <ø> (+0.1086%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6520% <ø> (+6.5776%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2024
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test label Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2024
@nolouch nolouch requested review from glorv and you06 July 4, 2024 07:27
@nolouch nolouch requested a review from JmPotato July 4, 2024 08:39
Copy link

ti-chi-bot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jul 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-04 08:41:30.049104606 +0000 UTC m=+1486616.534593438: ☑️ agreed by JmPotato.
  • 2024-07-04 08:55:37.854522146 +0000 UTC m=+1487464.340010978: ☑️ agreed by crazycs520.

@ti-chi-bot ti-chi-bot bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2024
Signed-off-by: nolouch <nolouch@gmail.com>
@glorv
Copy link
Contributor

glorv commented Jul 4, 2024

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9f7441a into pingcap:master Jul 4, 2024
23 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #54458.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #54459.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #54460.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #54461.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 4, 2024
5 tasks
@nolouch nolouch deleted the update-client branch July 5, 2024 02:22
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants