Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: push a handle into schema if datasource's schema have no col. #5447

Merged
merged 3 commits into from Dec 19, 2017

Conversation

winoros
Copy link
Member

@winoros winoros commented Dec 19, 2017

According to @AndreMouche , this will speed up sql's execution.

@winoros
Copy link
Member Author

winoros commented Dec 19, 2017

/run-all-tests

@winoros
Copy link
Member Author

winoros commented Dec 19, 2017

/run-integration-common-test

@hanfei1991
Copy link
Member

LGTM

@hanfei1991 hanfei1991 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2017
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood added all-tests-passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 19, 2017
@coocood coocood merged commit a807202 into pingcap:master Dec 19, 2017
@winoros winoros deleted the no-schema-send-handle branch December 19, 2017 13:22
@winoros
Copy link
Member Author

winoros commented Dec 19, 2017

i'll test whether we can just use a empty schema now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants