table: make slices in ColSizeDeltaBuffer private

[lcwangchao]

What problem does this PR solve?

Issue Number: close #54392

What changed and how does it work?

The inner slices in ColSizeDeltaBuffer should not be accessed directly for safe. This PR makes inner slices in ColSizeDeltaBuffer private and exposes another method UpdateColSizeMap to update col size.

This PR also removes UpdateDeltaForTableFromColSlice and use a unique function UpdateDeltaForTable to update the table delta.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9659%. Comparing base (f158c65) to head (451f164).
Report is 14 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54539         +/-   ##
=================================================
- Coverage   72.8179%   55.9659%   -16.8520%     
=================================================
  Files          1547       1670        +123     
  Lines        436240     610012     +173772     
=================================================
+ Hits         317661     341399      +23738     
- Misses        99004     245219     +146215     
- Partials      19575      23394       +3819     

Flag	Coverage Δ
integration	37.1640% <100.0000%> (?)
unit	71.7810% <100.0000%> (-0.0614%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	53.1488% <ø> (+7.2640%)	⬆️

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[YangKeao]

LGTM

[ekexium]

Have you benchmarked this change? UpdateDeltaForTableFromColSlice was introduced to optimize the heavy cost of maps in UpdateDeltaForTable in #53670

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

Have you benchmarked this change? UpdateDeltaForTableFromColSlice was introduced to optimize the heavy cost of maps in UpdateDeltaForTable in #53670

There is no sign significant difference in performance.

In mater:

➜  tidb git:(master) ✗ go test ./pkg/table/tables -run=^$ -bench=AddRecord -benchmem -benchtime=30s -cpuprofile=/tmp/cpu1.pprof
# github.com/pingcap/tidb/pkg/table/tables.test
ld: warning: -bind_at_load is deprecated on macOS
goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/pkg/table/tables
BenchmarkAddRecordInPipelinedDML-10    	    2946	  11896529 ns/op	      1190 ns/record	 2742043 B/op	   90310 allocs/op
PASS
ok  	github.com/pingcap/tidb/pkg/table/tables	41.815s

This PR:

➜  tidb git:(delta_cols_buffer) go test ./pkg/table/tables -run=^$ -bench=AddRecord -benchmem -benchtime=30s -cpuprofile=/tmp/cpu2.pprof
# github.com/pingcap/tidb/pkg/table/tables.test
ld: warning: -bind_at_load is deprecated on macOS
goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/pkg/table/tables
BenchmarkAddRecordInPipelinedDML-10    	    2943	  11928920 ns/op	      1193 ns/record	 2741946 B/op	   90310 allocs/op
PASS
ok  	github.com/pingcap/tidb/pkg/table/tables	41.889s

What we removed is UpdateDeltaForTable, actually. And then rename UpdateDeltaForTableFromColSlice to UpdateDeltaForTable.

[ekexium]

Okay I see

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-10 09:55:35.163013585 +0000 UTC m=+437832.398247699: ☑️ agreed by YangKeao.
• 2024-07-11 04:41:20.234997862 +0000 UTC m=+505377.470231971: ☑️ agreed by ekexium.

[easonn7]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, ekexium, lance6716, tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YangKeao,ekexium,lance6716,tangenta]
• pkg/executor/importer/OWNERS [lance6716]
• pkg/sessionctx/variable/OWNERS [easonn7]
• pkg/table/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment