Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Close() executors when Open() returns an error to avoid goroutine leak (#5469) #5486

Merged
merged 1 commit into from Dec 25, 2017
Merged

executor: Close() executors when Open() returns an error to avoid goroutine leak (#5469) #5486

merged 1 commit into from Dec 25, 2017

Conversation

tiancaiamao
Copy link
Contributor

Cherry pick from master

winkyao
winkyao reviewed Dec 25, 2017
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coocood
coocood approved these changes Dec 25, 2017
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 2cccadc into pingcap:release-1.0 Dec 25, 2017
@tiancaiamao tiancaiamao deleted the release-open branch April 24, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiancaiamao @coocood @winkyao @zz-jason