Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix bug when build histograms for null json #5545

Merged
merged 5 commits into from Jan 4, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jan 3, 2018

When the json value is null literal, the upper bound may not be set because it is equal to a null datum.

@shenli
Copy link
Member

shenli commented Jan 3, 2018

Please fix the CI.
Do we need to update coprocessor?

@alivxxx
Copy link
Contributor Author

alivxxx commented Jan 3, 2018

@shenli No need to.

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut
Copy link
Member

ngaut commented Jan 4, 2018

/run-all-tests

@shenli
Copy link
Member

shenli commented Jan 4, 2018

LGTM

@shenli shenli added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 4, 2018
@shenli shenli merged commit 835b764 into pingcap:master Jan 4, 2018
@alivxxx alivxxx deleted the json branch January 4, 2018 05:16
alivxxx added a commit to alivxxx/tidb that referenced this pull request Jan 4, 2018
winoros pushed a commit that referenced this pull request Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants