Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser, expression: support SEPARATOR in group_concat aggregate function #5569

Merged
merged 1 commit into from Jan 6, 2018

Conversation

@winkyao
Copy link
Member

commented Jan 6, 2018

No description provided.

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2018

@shenli @coocood PTAL it's a cherry-pick..

@coocood

This comment has been minimized.

Copy link
Member

commented Jan 6, 2018

/run-all-tests tidb-test=release-1.0 tikv=release-1.0 tidb-private-test=release-1.0

@shenli

This comment has been minimized.

Copy link
Member

commented Jan 6, 2018

LGTM

@coocood
coocood approved these changes Jan 6, 2018
Copy link
Member

left a comment

LGTM

@coocood coocood merged commit c67e2cd into pingcap:release-1.0 Jan 6, 2018
12 checks passed
12 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on release-1.0 at 72.441%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@winkyao winkyao deleted the winkyao:cherry-pick branch Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.