Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser, expression: support SEPARATOR in group_concat aggregate function #5569

Merged
merged 1 commit into from Jan 6, 2018
Merged

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jan 6, 2018

No description provided.

@winkyao
Copy link
Contributor Author

winkyao commented Jan 6, 2018

@shenli @coocood PTAL it's a cherry-pick..

@coocood
Copy link
Member

coocood commented Jan 6, 2018

/run-all-tests tidb-test=release-1.0 tikv=release-1.0 tidb-private-test=release-1.0

@shenli
Copy link
Member

shenli commented Jan 6, 2018

LGTM

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit c67e2cd into pingcap:release-1.0 Jan 6, 2018
@winkyao winkyao deleted the cherry-pick branch January 7, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants