aggregation, plan: split the presentation and evaluation layers of aggregation functions #5635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gregation functions
|
/run-all-tests |
|
Please add a few description for the PR. |
|
/run-all-tests tidb-test=pr/446 |
|
Cool |
alivxxx
reviewed
Jan 15, 2018
expression/aggregation/descriptor.go
Outdated
| // TODO: a.Args[0] = expression.WrapWithCastAsInt(ctx, a.Args[0]) | ||
| } | ||
|
|
||
| func (a *AggFuncDesc) calculateDefaultVale4Count(ctx context.Context, schema *expression.Schema) (types.Datum, bool) { |
coocood
reviewed
Jan 15, 2018
expression/aggregation/descriptor.go
Outdated
| } | ||
|
|
||
| // GetEvaluator gets an evaluator according to the aggregation function signature. | ||
| func (a *AggFuncDesc) GetEvaluator() Aggregation { |
There was a problem hiding this comment.
How about just GetAggFunc or GetAggregation?
We can distinguish it from Aggregation by Desc already.
alivxxx
reviewed
Jan 15, 2018
plan/aggregation_push_down.go
Outdated
| firstRow := aggregation.NewAggFunction(ast.AggFuncFirstRow, []expression.Expression{gbyCol.Clone()}, false) | ||
| newAggFuncs = append(newAggFuncs, firstRow) | ||
| firstRow := aggregation.NewAggFuncDesc(ast.AggFuncFirstRow, []expression.Expression{gbyCol.Clone()}, false) | ||
| firstRow.TypeInfer(agg.ctx) |
There was a problem hiding this comment.
How about just combine the TypeInfer and NewFuncDesc for the complete model? Almost every NewFuncDesc is followed by TypeInfer.
|
LGTM |
alivxxx
reviewed
Jan 15, 2018
plan/property_cols_prune.go
Outdated
| @@ -39,6 +39,10 @@ func (p *LogicalSelection) preparePossibleProperties() (result [][]*expression.C | |||
| return p.children[0].preparePossibleProperties() | |||
| } | |||
|
|
|||
| func (p *LogicalProjection) preparePossibleProperties() (result [][]*expression.Column) { | |||
| return p.children[0].(LogicalPlan).preparePossibleProperties() | |||
There was a problem hiding this comment.
No need to do type assertion. Also, this is an irrelevant change?
… into dev/plan/aggregation
alivxxx
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, I split the
Aggregationinterface to presentation and evaluation layers.AggFuncDescto describe an aggregation function, witch contains all the informations and APIs needed by planner.Aggregationinterface to represent the evaluator of a particularAggFuncDescobject, irrelevant APIs are removed.AggFuncDesc.GetAggFunc()to get the an instance ofAggregationas the corresponding evaluator.After this PR, we are able to: