Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.0: only set DefaultValues in agg push down. #5712

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
3 participants
@winoros
Copy link
Member

commented Jan 25, 2018

The code of #5383 in executor package is hard to pick up. So rewrite this part.
PTAL @XuHuaiyu @zz-jason @hanfei1991

@zz-jason
Copy link
Member

left a comment

LGTM

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2018

/run-all-tests tidb-test=release-1.0 tikv=release-1.0 tidb-private-test=release-1.0

@XuHuaiyu
Copy link
Contributor

left a comment

LGTM

@winoros winoros merged commit 4913f64 into pingcap:release-1.0 Jan 25, 2018

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on release-1.0 at 72.493%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winoros winoros deleted the winoros:pick branch Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.