Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix shard show id bug #5751

Merged
merged 1 commit into from Jan 30, 2018
Merged

Conversation

zimulala
Copy link
Contributor

The master is OK, but the release 1.0 is wrong.
Because the job's state is wrong when cherry picks the operation to release 1.0
original PR #5513
cherry-pick PR #5559

@coocood
Copy link
Member

coocood commented Jan 30, 2018

LGTM

@zimulala
Copy link
Contributor Author

/run-all-test tidb-test=release-1.0

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 30, 2018
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=release-1.0 tidb-private-test=release-1.0 tikv=release-1.0

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 30, 2018
@shenli shenli merged commit ef9452d into pingcap:release-1.0 Jan 30, 2018
@zimulala zimulala deleted the shard-row-id branch January 30, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants