Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix shard show id bug #5751

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@zimulala
Copy link
Member

commented Jan 30, 2018

The master is OK, but the release 1.0 is wrong.
Because the job's state is wrong when cherry picks the operation to release 1.0
original PR #5513
cherry-pick PR #5559

@coocood

This comment has been minimized.

Copy link
Member

commented Jan 30, 2018

LGTM

@zimulala

This comment has been minimized.

Copy link
Member Author

commented Jan 30, 2018

/run-all-test tidb-test=release-1.0

@winkyao
Copy link
Member

left a comment

LGTM

@zimulala

This comment has been minimized.

Copy link
Member Author

commented Jan 30, 2018

/run-all-tests tidb-test=release-1.0 tidb-private-test=release-1.0 tikv=release-1.0

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Jan 30, 2018

@shenli shenli merged commit ef9452d into pingcap:release-1.0 Jan 30, 2018

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on release-1.0 at 72.486%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zimulala zimulala deleted the zimulala:shard-row-id branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.