importer: generate int data by histogram #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Feb 5, 2018
cmd/importer/main.go
Outdated
| for _, idxInfo := range table.tblInfo.Indices { | ||
| offset := idxInfo.Columns[0].Offset | ||
| if hist, ok := statsInfo.Indices[idxInfo.ID]; ok { | ||
| log.Warnf("index offset %d", offset) |
cmd/importer/stats.go
Outdated
| index *model.IndexInfo | ||
| } | ||
|
|
||
| func (h *histogram) getRandomBoundIdx() int { |
There was a problem hiding this comment.
Please add comments about the difference between odd and even index.
|
@coocood PTAL |
|
LGTM |
| // When the cnt falls in the middle of bucket, we return the idx of lower bound which is an even number. | ||
| // When the cnt falls in the end of bucket, we return the upper bound which is odd. | ||
| func (h *histogram) getRandomBoundIdx() int { | ||
| cnt := h.Buckets[len(h.Buckets)-1].Count |
There was a problem hiding this comment.
is that possible len(h.Buckets) = 0 ? this may cause panic
|
@WangXiangUSTC fixed by checking len of buckets after decoding stats file. PTAL |
|
LGTM |
WangXiangUSTC
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pending to support more types.