New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix in-compatible behavior when modify value from Navicat GUI #6105
Conversation
/run-all-tests |
types/field_type.go
Outdated
@@ -55,7 +55,7 @@ func NewFieldType(tp byte) *FieldType { | |||
// Equal checks whether two FieldType objects are equal. | |||
func (ft *FieldType) Equal(other *FieldType) bool { | |||
partialEqual := ft.Tp == other.Tp && | |||
ft.Flag == other.Flag && | |||
//ft.Flag == other.Flag && // We do not need to compare this when wrap cast upon an Expression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is strange to comment inside a statement. Could we explain this above line 57?
PTAL @jackysp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit fix 2 things which will affect modify values from Navicat GUI,
and remove comparison of FieldType.Flag when mergeFiledType for Union. :
Group_concat( order by)
Before this commit:
numeric type
columnsBefore this commit: