Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix syntax error on sql "set transaction isolation level serializable;" #6131

Merged
merged 5 commits into from Mar 24, 2018
Merged

fix syntax error on sql "set transaction isolation level serializable;" #6131

merged 5 commits into from Mar 24, 2018

Conversation

qxhy123
Copy link
Contributor

@qxhy123 qxhy123 commented Mar 23, 2018

No description provided.

@coocood
Copy link
Member

coocood commented Mar 23, 2018

@qxhy123
Please add test in parser/parser_test.go.

@coocood
Copy link
Member

coocood commented Mar 23, 2018

LGTM

@qxhy123 Thank you!

@coocood coocood added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2018
@shenli shenli added the contribution This PR is from a community contributor. label Mar 23, 2018
@shenli
Copy link
Member

shenli commented Mar 23, 2018

LGTM

@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2018
@shenli
Copy link
Member

shenli commented Mar 23, 2018

/run-all-tests

@winkyao
Copy link
Contributor

winkyao commented Mar 23, 2018

/run-integration-common-test

@shenli
Copy link
Member

shenli commented Mar 23, 2018

/run-integration-common-test

@coocood coocood merged commit b6b708a into pingcap:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qxhy123 @coocood @shenli @winkyao