executor: support range column in show create table #6332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
alivxxx
reviewed
Apr 23, 2018
executor/show.go
Outdated
| multipleLt := false | ||
| for j, lessThan := range def.LessThan { | ||
| if j > 0 { | ||
| lessThans = lessThans + "," + lessThan |
There was a problem hiding this comment.
What is the difference between strings.Join and +?
executor/show.go
Outdated
| if i < len(partitionInfo.Definitions)-1 { | ||
| buf.WriteString(fmt.Sprintf(" PARTITION %s VALUES LESS THAN %s,\n", def.Name, def.LessThan[0])) | ||
| if multipleLt { |
There was a problem hiding this comment.
We can just check it outside this if block and add () to lessThans if necessary.
|
@lamxTyler PTAL |
|
LGTM |
zhexuany
force-pushed
the
support_range_column_in_show_create_table
branch
from
ee4a3de
to
8a64c58
Compare
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to support range columns partition in show create table statement.