*: add schema version to the log #6527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
PTAL @tiancaiamao @coocood @shenli |
shenli
reviewed
May 10, 2018
domain/domain.go
Outdated
| @@ -99,8 +99,8 @@ func (do *Domain) loadInfoSchema(handle *infoschema.Handle, usedSchemaVersion in | |||
| log.Errorf("[ddl] failed to load schema diff err %v", err) | |||
| } | |||
| if ok { | |||
| log.Infof("[ddl] diff load InfoSchema from version %d to %d, in %v", | |||
| usedSchemaVersion, latestSchemaVersion, time.Since(startTime)) | |||
| log.Infof("[ddl] diff load InfoSchema from version %d to %d in %v, tbls %v", | |||
There was a problem hiding this comment.
It's better not to use abbreviation here.
If we're reading this function, this is OK because we have the context information, but when it used in log, we have no idea what's the abbreviation for.
There was a problem hiding this comment.
And when OPS see this log, he might thought: "what the fuck?"
session/session.go
Outdated
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
|
|
||
| if retryCnt == 0 { | ||
| // We do not have to log the query every time. | ||
| // We print the queries at the first try only. | ||
| log.Warnf("[%d] Retry [%d] query [%d] %s", connID, retryCnt, i, sqlForLog(st.OriginText())) | ||
| log.Warnf("[con:%d][ver:%d] Retry [%d] query [%d] %s", connID, schemaVersion, retryCnt, i, sqlForLog(st.OriginText())) |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
|
/run-all-tests |
|
@zimulala Please address the comments. |
|
PTAL @shenli @tiancaiamao |
|
LGTM |
tiancaiamao
added
1.0-cherry-pick
status/LGT1
zimulala
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information schema version to the log.