plan: fix a bug in rebuildRange when enabling prepare-plan-cache.
#6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
reviewed
May 24, 2018
| @@ -0,0 +1,51 @@ | |||
| package plan_test | |||
There was a problem hiding this comment.
Will this test case cover this bug? If we revert the modification in common_plans.go, will this case fail?
jackysp
reviewed
May 24, 2018
plan/errors.go
Outdated
| @@ -1,100 +0,0 @@ | |||
| // Copyright 2018 PingCAP, Inc. | |||
|
/run-all-tests |
XuHuaiyu
reviewed
May 24, 2018
plan/prepare_test.go
Outdated
| @@ -0,0 +1,65 @@ | |||
| // Copyright 2017 PingCAP, Inc. | |||
|
I've tested this pr by TPC-C. LGTM |
|
@winoros Do we need to cherry pick this one to release-2.0? |
winoros
added a commit
to winoros/tidb
that referenced
this pull request
May 30, 2018
…ingcap#6637) * plan: fix a bug in `rebuildRange` when enabling prepare-plan-cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It cannot build range successfully if the plan is an index plan.
PTAL @lamxTyler @zz-jason @XuHuaiyu @jackysp