Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix a bug in predicate push down phase. #6809

Merged
merged 6 commits into from Jun 12, 2018
Merged

Conversation

winoros
Copy link
Member

@winoros winoros commented Jun 11, 2018

What have you changed? (mandatory)

fix a bug when the join is right join and some predicate pushed across the join to the right child.

What are the type of the changes (mandatory)?

The currently defined types are listed below, please pick one of the types for this PR by removing the others:

  • Bug fix

How has this PR been tested (mandatory)?

unit-test in executor package.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the type/bug-fix This PR fixes a bug. label Jun 11, 2018
@shenli
Copy link
Member

shenli commented Jun 11, 2018

LGTM

@shenli
Copy link
Member

shenli commented Jun 11, 2018

/run-all-tests

@winoros
Copy link
Member Author

winoros commented Jun 11, 2018

/run-unit-test

@shenli shenli added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 11, 2018
@shenli
Copy link
Member

shenli commented Jun 11, 2018

/run-all-tests

@ngaut ngaut merged commit 69fdc8d into pingcap:master Jun 12, 2018
@winoros winoros deleted the ppd-bug branch June 12, 2018 04:39
winoros added a commit to winoros/tidb that referenced this pull request Jun 12, 2018
* plan: fix a bug in `predicate push down` phase.
ngaut pushed a commit that referenced this pull request Jun 12, 2018
* plan: fix a bug in `predicate push down` phase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants