Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Make 'IF NOT EXISTS' great again in 'CREATE TABLE IF NOT EXISTS LIKE' syntax (#6896) #6928

Merged
merged 4 commits into from Jul 3, 2018
Merged

*: Make 'IF NOT EXISTS' great again in 'CREATE TABLE IF NOT EXISTS LIKE' syntax (#6896) #6928

merged 4 commits into from Jul 3, 2018

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Jun 28, 2018 •
edited

What have you changed? (mandatory)

cherry pick #6896 to release 2.0

What are the type of the changes (mandatory)?

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested (mandatory)?

  • unit test
  • explain test

jackysp
jackysp reviewed Jun 28, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

s/6869/6896

@shenli
Copy link
Member

shenli commented Jul 2, 2018

@zz-jason Please fix the CI.

@shenli
Copy link
Member

shenli commented Jul 2, 2018

LGTM

@shenli shenli added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 2, 2018
@zz-jason
Copy link
Member Author

zz-jason commented Jul 3, 2018

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

zimulala
zimulala approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 3, 2018
@zz-jason zz-jason merged commit 9cefb33 into pingcap:release-2.0 Jul 3, 2018
@zz-jason zz-jason deleted the cherrypick/duchuan-6896 branch July 3, 2018 03:33
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zz-jason @zimulala @shenli @jackysp @you06 @spongedu