New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: kill one's own connection doesn't require SUPER privilege (#6954) #7003

Merged
merged 2 commits into from Jul 6, 2018

Conversation

Projects
None yet
5 participants
@tiancaiamao
Contributor

tiancaiamao commented Jul 6, 2018

What have you changed? (mandatory)

cherry pick from #6954

`kill tidb connID`, if the user is the owner of that connection, there
is no need to check the SUPER privilege.
SessionManager interface is slightly modified.

What are the type of the changes (mandatory)?

  • Bug fix (non-breaking change which fixes an issue)
*: kill one's own connection doesn't require SUPER privilege (#6954)
`kill tidb connID`, if the user is the owner of that connection, there
is no need to check the SUPER privilege.
SessionManager interface is slightly modified.
@shenli

This comment has been minimized.

Member

shenli commented Jul 6, 2018

  1. The title has nothing to do with the content.
  2. Please add proper labels to this PR.

@tiancaiamao tiancaiamao changed the title from privilege/privileges: don't reuse chunk in loadTable function (#6976) to *: kill one's own connection doesn't require SUPER privilege (#6954) Jul 6, 2018

@tiancaiamao

This comment has been minimized.

Contributor

tiancaiamao commented Jul 6, 2018

@tiancaiamao

This comment has been minimized.

Contributor

tiancaiamao commented Jul 6, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@jackysp

jackysp approved these changes Jul 6, 2018

LGTM

@tiancaiamao

This comment has been minimized.

Contributor

tiancaiamao commented Jul 6, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason merged commit 3835845 into pingcap:release-2.0 Jul 6, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason added the status/LGT2 label Jul 6, 2018

@tiancaiamao tiancaiamao deleted the tiancaiamao:cherry-pick branch Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment