Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix drop user bug (#6624) #7014

Merged
merged 1 commit into from Jul 9, 2018

Conversation

@zhexuany
Copy link
Member

commented Jul 9, 2018

Thank you for working on TiDB! Please read TiDB's CONTRIBUTING document BEFORE filing this PR.

What have you changed? (mandatory)

This is a cherry-pick pr. Refer to #6624

What are the type of the changes (mandatory)?

cherry-pick

@zhexuany zhexuany requested review from tiancaiamao and coocood Jul 9, 2018

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2018

This addresses issue #7007. @tiancaiamao @coocood please review this cherry-pick if you guys have time. ;)

@coocood

This comment has been minimized.

Copy link
Member

commented Jul 9, 2018

LGTM

@coocood coocood added the status/LGT1 label Jul 9, 2018

@tiancaiamao tiancaiamao changed the title [cherry-pick] executor: fix drop user bug (#6624) executor: fix drop user bug (#6624) Jul 9, 2018

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2018

LGTM

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@tiancaiamao tiancaiamao added status/LGT2 and removed status/LGT1 labels Jul 9, 2018

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2018

Thanks for quick response @coocood @tiancaiamao ;)

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2018

@shenli friendly ping. This cherry-pick was already approved.

@shenli shenli merged commit cef80ce into pingcap:release-2.0 Jul 9, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zhexuany zhexuany deleted the zhexuany:cherry_pick_pr_6624 branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.