Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tables: fix prefix index, when the charset is utf8, truncate it from runes (#7109) #7126

Merged
merged 1 commit into from Jul 23, 2018
Merged

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jul 23, 2018

What have you changed? (mandatory)

Cherry-pick from #7109

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

UT

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

NO

Does this PR affect tidb-ansible update? (mandatory)

NO

Does this PR need to be added to the release notes? (mandatory)

YES, fix prefix index, when the charset is utf8 or utf8mb4, truncate it from runes.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciscoxll ciscoxll added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2018
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2018
@coocood
Copy link
Member

coocood commented Jul 23, 2018

/run-common-test tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor Author

winkyao commented Jul 23, 2018

/run-common-test tidb-test=release-2.0 tikv=release-2.0

@shenli shenli merged commit 0338239 into pingcap:release-2.0 Jul 23, 2018
@winkyao winkyao deleted the cherry-pick-2.0 branch July 23, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants