Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tables: fix prefix index, when the charset is utf8, truncate it from runes (#7109) #7126

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
6 participants
@winkyao
Copy link
Member

winkyao commented Jul 23, 2018

What have you changed? (mandatory)

Cherry-pick from #7109

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

UT

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

NO

Does this PR affect tidb-ansible update? (mandatory)

NO

Does this PR need to be added to the release notes? (mandatory)

YES, fix prefix index, when the charset is utf8 or utf8mb4, truncate it from runes.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@ciscoxll
Copy link
Contributor

ciscoxll left a comment

LGTM

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Jul 23, 2018

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Jul 23, 2018

@coocood

This comment has been minimized.

Copy link
Member

coocood commented Jul 23, 2018

/run-common-test tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@crazycs520
Copy link
Contributor

crazycs520 left a comment

LGTM

@winkyao

This comment has been minimized.

Copy link
Member Author

winkyao commented Jul 23, 2018

/run-common-test tidb-test=release-2.0 tikv=release-2.0

@shenli shenli merged commit 0338239 into pingcap:release-2.0 Jul 23, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao:cherry-pick-2.0 branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.