Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: reduce conflict for updating column size (#7124) #7138

Merged
merged 2 commits into from Jul 24, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jul 24, 2018

What have you changed? (mandatory)

Cherry pick #7124

What is the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Unit test.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Does this PR need to be added to the release notes? (mandatory)

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

winoros
winoros previously approved these changes Jul 24, 2018
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx
Copy link
Contributor Author

alivxxx commented Jul 24, 2018

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx
Copy link
Contributor Author

alivxxx commented Jul 24, 2018

/run-common-test tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@alivxxx
Copy link
Contributor Author

alivxxx commented Jul 24, 2018

/run-common-test tidb-test=release-2.0 tikv=release-2.0

@coocood coocood merged commit c028f5f into pingcap:release-2.0 Jul 24, 2018
@alivxxx alivxxx deleted the confict branch July 24, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants