Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: reduce conflict for updating column size (#7124) #7138

Merged
merged 2 commits into from Jul 24, 2018

Conversation

@lamxTyler
Copy link
Member

commented Jul 24, 2018

What have you changed? (mandatory)

Cherry pick #7124

What is the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Unit test.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Does this PR need to be added to the release notes? (mandatory)

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@winoros
Copy link
Member

left a comment

lgtm

@lysu
lysu approved these changes Jul 24, 2018
Copy link
Member

left a comment

LGTM

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2018

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@zimulala
Copy link
Member

left a comment

LGTM

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2018

/run-common-test tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2018

/run-common-test tidb-test=release-2.0 tikv=release-2.0

@coocood coocood merged commit c028f5f into pingcap:release-2.0 Jul 24, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the lamxTyler:confict branch Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.