Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug that nullable unique index can not find null values using index. (#7163) #7172

Merged
merged 1 commit into from Jul 29, 2018

Conversation

@winkyao
Copy link
Member

commented Jul 27, 2018

What have you changed? (mandatory)

Cherry-pick from #7163

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

ut

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Does this PR need to be added to the release notes? (mandatory)

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@winoros
Copy link
Member

left a comment

lgtm

@shenli shenli added the status/LGT1 label Jul 27, 2018

@shenli

This comment has been minimized.

Copy link
Member

commented Jul 27, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 tidb-private-test=release-2.0

@shenli

This comment has been minimized.

Copy link
Member

commented Jul 27, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@zimulala
Copy link
Member

left a comment

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Jul 28, 2018

@coocood coocood merged commit 1672248 into pingcap:release-2.0 Jul 29, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao:cherry-pick-2.0 branch Jul 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.