mocktikv: return Chunk encoded data #7191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Jul 31, 2018
| encoder := chunk.NewCodec(respColTypes) | ||
| for i := range rows { | ||
| for j, ordinal := range colOrdinal { | ||
| colDatum, err := tablecodec.DecodeColumnValue(rows[i][ordinal], colTypes[ordinal], loc) |
There was a problem hiding this comment.
We can use codec.NewDecoder and (*Decoder).DecodeOne.
AndreMouche
reviewed
Aug 3, 2018
| for _, ordinal := range colOrdinal { | ||
| respColTypes = append(respColTypes, colTypes[ordinal]) | ||
| } | ||
| chk := chunk.NewChunkWithCapacity(respColTypes, 32) |
There was a problem hiding this comment.
should the capacity equals rowsPerChunk?
2 tasks
|
/run-all-tests |
|
/run-integration-common-test tikv=pr/3398 |
AndreMouche
reviewed
Aug 14, 2018
| respColTypes = append(respColTypes, colTypes[ordinal]) | ||
| } | ||
|
|
||
| chk := chunk.NewChunkWithCapacity(respColTypes, 32) |
There was a problem hiding this comment.
where does the 32 come from? Should it be equal to rowsPerChunk?
There was a problem hiding this comment.
Uh.. Yes, it should better be equal to rowsPerChunk. I'll refactor this. BTW, 32 does not affect the correctness.
|
/run-integration-common-test tikv=pr/3398 |
|
/run-common-test |
|
/run-integration-common-test tikv=pr/3398 |
|
/run-integration-common-test tikv=pr/3398 |
|
/run-integration-common-test tikv=pr/3398 |
|
closed due to outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
return chunk-encoded data when the requested
EncodeTypeisTypeArrow.What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
Does this PR affect tidb-ansible update? (mandatory)
Does this PR need to be added to the release notes? (mandatory)
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)