Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binlog: fix bug in load data #7242

Merged
merged 2 commits into from Aug 2, 2018

Conversation

@coocood
Copy link
Member

commented Aug 2, 2018

Cherry-pick #7074

What have you changed?

  1. some tiny fix when commit txn for load data
  2. remove prewritevalue in commit binlog

What is the type of the changes?

Bug fix

  1. when data is less than 20000 line, load data will not generate binlog
  2. commit binlog shouldn't have prewritevalue
  3. the binlog size will be bigger than the last time when load data, and may cause oom, should reset the binlog.

How has this PR been tested?

load data less than 20000 line.

Refer to a related issue link

#7035

@lysu

This comment has been minimized.

Copy link
Member

commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zimulala
Copy link
Member

left a comment

LGTM

@zimulala zimulala added the status/LGT1 label Aug 2, 2018

@lysu
lysu approved these changes Aug 2, 2018
Copy link
Member

left a comment

LGTM

@coocood coocood merged commit c04b9a7 into pingcap:release-2.0 Aug 2, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:binlog-release-2.0 branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.