Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog: fix bug in load data #7242

Merged
merged 2 commits into from
Aug 2, 2018
Merged

binlog: fix bug in load data #7242

merged 2 commits into from
Aug 2, 2018

Conversation

coocood
Copy link
Member

@coocood coocood commented Aug 2, 2018

Cherry-pick #7074

What have you changed?

  1. some tiny fix when commit txn for load data
  2. remove prewritevalue in commit binlog

What is the type of the changes?

Bug fix

  1. when data is less than 20000 line, load data will not generate binlog
  2. commit binlog shouldn't have prewritevalue
  3. the binlog size will be bigger than the last time when load data, and may cause oom, should reset the binlog.

How has this PR been tested?

load data less than 20000 line.

Refer to a related issue link

#7035

@lysu
Copy link
Contributor

lysu commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

zimulala
zimulala approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2018
lysu
lysu approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2018
@coocood coocood merged commit c04b9a7 into pingcap:release-2.0 Aug 2, 2018
@coocood coocood deleted the binlog-release-2.0 branch August 2, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@coocood @lysu @zimulala @zz-jason @WangXiangUSTC @shenli