Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: init builder startTS in `buildTableDual` #7246

Merged
merged 2 commits into from Aug 2, 2018

Conversation

@coocood
Copy link
Member

commented Aug 2, 2018

Cherry-pick #6830

What have you changed? (mandatory)

When we build an index join executor with outer table is table dual, we never call b.getStartTS during build time.
But later when we execute the query, we use the builder to build inner table which needs startTS, but by then, the transaction is set to invalid, then we panic.

This PR init the startTS in executorBuilder.buildTableDual to fix the panic issue.

What are the type of the changes (mandatory)?

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested (mandatory)?

  • unit-test
@coocood

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@XuHuaiyu
Copy link
Contributor

left a comment

LGTM

@shenli

This comment has been minimized.

Copy link
Member

commented Aug 2, 2018

LGTM

@shenli
shenli approved these changes Aug 2, 2018
@coocood

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

/run-mybatis-test tikv=release-2.0 tidb-test=release-2.0

@coocood coocood merged commit 491d446 into pingcap:release-2.0 Aug 2, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:builder-start-ts-2.0 branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.