Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fixed some typos. #7277

Merged
merged 2 commits into from Aug 5, 2018

Conversation

@mccxj
Copy link
Contributor

commented Aug 4, 2018

What have you changed? (mandatory)

Just fix some typos.

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Not more unit test is added.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

No

mccxj added 2 commits Aug 4, 2018
@winkyao

This comment has been minimized.

Copy link
Member

commented Aug 4, 2018

The type of these changes may be an improvement, not bugfix?

@winkyao
winkyao approved these changes Aug 4, 2018
Copy link
Member

left a comment

LGTM

@ngaut
ngaut approved these changes Aug 4, 2018
Copy link
Member

left a comment

LGTM

@ngaut ngaut merged commit 6178cfd into pingcap:master Aug 5, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@mccxj mccxj deleted the mccxj:typo branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.