Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fixed some typos. #7277

Merged
merged 2 commits into from Aug 5, 2018
Merged

*: fixed some typos. #7277

merged 2 commits into from Aug 5, 2018

Conversation

mccxj
Copy link
Contributor

@mccxj mccxj commented Aug 4, 2018

What have you changed? (mandatory)

Just fix some typos.

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Not more unit test is added.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

No

@winkyao
Copy link
Contributor

winkyao commented Aug 4, 2018

The type of these changes may be an improvement, not bugfix?

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut merged commit 6178cfd into pingcap:master Aug 5, 2018
@mccxj mccxj deleted the typo branch August 5, 2018 14:03
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants