ddl: adjust the way of checking all schema versions #7319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
PTAL @coocood @winkyao @tiancaiamao |
|
LGTM |
coocood
added
status/LGT3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
In PR #6955, we have two workers to generate the latest schema version and update the global version. The case as follows(about 1 TiDB server):
Worker1's latest schema version is 134, it updates the global version on PD to 134.
Then worker2's latest schema version is 135, it updates the global version on PD to 135.
And the server loads information schema version 135.
Worker2 handles "OwnerCheckAllVersions" successfully.
But at this time, worker1 will meet the log like
syncer.go:344: [info] [syncer] check all versions, ddl /tidb/ddl/all_schema_versions/317220cc-7fc6-4930-a1c0-21fa615de376 is not synced, current ver 135, latest version 134, continue checkingwhen handling "OwnerCheckAllVersions".What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Relate to pingcap/tidb-test#598
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Does this PR need to be added to the release notes? (mandatory)
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)