Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the issue of executing DDL after executing SQL failure in txn … #8056

Merged
merged 2 commits into from
Oct 29, 2018

Conversation

zimulala
Copy link
Contributor

  • ddl, executor: fix the issue of executing DDL after executing SQL failure in txn

What problem does this PR solve?

cherry-pick #8044
Fix the issue of the following case:

  • Execute the SQL of "begin";
  • A SQL that will fail to execute;
  • Execute DDL.

…ingcap#8044)

* ddl, executor: fix the issue of executing DDL after executing SQL failure in txn
@zimulala
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor

/run-common-test tidb-test=release-2.1

@tiancaiamao
Copy link
Contributor

/run-common-test tidb-test=pr/635

@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=release-2.1

@zz-jason
Copy link
Member

@zimulala There is a data race in "unit-test"

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2018
@zimulala
Copy link
Contributor Author

@zz-jason
It's an unstable test. This issue is not related to the current PR.
I will rerun this test.

@zimulala
Copy link
Contributor Author

/run-unit-test

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 29, 2018
@zimulala
Copy link
Contributor Author

/run-all-tests

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit 423e9b6 into pingcap:release-2.1 Oct 29, 2018
@zimulala zimulala deleted the cp-8044 branch October 30, 2018 13:18
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants